This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Switch Pulp to use sqlite3 as default #3344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you can update the Travis file to run against both sqlite and PostgreSQL? It would be a good check to ensure compatibility with both databases. Edit: I think these changes should work. |
daviddavis
reviewed
Feb 27, 2018
pulpcore/pulpcore/app/settings.py
Outdated
| 'NAME': 'pulp', | ||
| 'USER': 'pulp', | ||
| 'ENGINE': 'django.db.backends.sqlite3', | ||
| 'NAME': '', |
There was a problem hiding this comment.
Looks like you still need a db name here.
There was a problem hiding this comment.
yeah ... thename should be 'pulp'
This PR enables testing on both postgresql and sqlite. Thanks to @daviddavis for the .travis file changes! re pulp#3359
|
I pushed those changes, but it says it's running Ruby for some reason on Travis? This Job has config: hmmmm? |
|
ok test |
|
The .travis.yml had bad escaping in it and Travis couldn't parse it. So it reverted to the default language (ruby). I've fixed it here though: #3348. Apologies! |
daviddavis
reviewed
Mar 1, 2018
| # NAME: pulp | ||
| # USER: pulp | ||
| # ENGINE: django.db.backends.sqlite3 | ||
| # NAME: |
There was a problem hiding this comment.
fyi, this needs to be 'pulp'
|
Closing because daviddavis fixed it! #3348 (review) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/3359
closes #3359